pinctrl: ocelot: Remove unnecessary conversion to bool
authorKaixu Xia <kaixuxia@tencent.com>
Fri, 6 Nov 2020 08:36:35 +0000 (16:36 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 10 Nov 2020 14:08:27 +0000 (15:08 +0100)
Fix the following coccicheck warning:

./drivers/pinctrl/pinctrl-ocelot.c:732:28-33: WARNING: conversion to bool not needed here

Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Link: https://lore.kernel.org/r/1604651795-1220-1-git-send-email-kaixuxia@tencent.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-ocelot.c

index a4a1b00..c2be5c4 100644 (file)
@@ -729,7 +729,7 @@ static int ocelot_pinconf_get(struct pinctrl_dev *pctldev,
                if (err)
                        return err;
                if (param == PIN_CONFIG_BIAS_DISABLE)
-                       val = (val == 0 ? true : false);
+                       val = (val == 0);
                else if (param == PIN_CONFIG_BIAS_PULL_DOWN)
                        val = (val & BIAS_PD_BIT ? true : false);
                else    /* PIN_CONFIG_BIAS_PULL_UP */