ipmi: missing error code in try_smi_init()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 6 Mar 2018 09:58:03 +0000 (12:58 +0300)
committerCorey Minyard <cminyard@mvista.com>
Wed, 7 Mar 2018 01:47:52 +0000 (19:47 -0600)
If platform_device_alloc() then we should return -ENOMEM instead of
returning success.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
drivers/char/ipmi/ipmi_si_intf.c

index f2a294f..ff870aa 100644 (file)
@@ -2071,6 +2071,7 @@ static int try_smi_init(struct smi_info *new_smi)
                                                      new_smi->intf_num);
                if (!new_smi->pdev) {
                        pr_err(PFX "Unable to allocate platform device\n");
+                       rv = -ENOMEM;
                        goto out_err;
                }
                new_smi->io.dev = &new_smi->pdev->dev;