regulator: lp87565: Use bitfield helpers
authorGeert Uytterhoeven <geert+renesas@glider.be>
Thu, 15 Feb 2024 13:10:50 +0000 (14:10 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 15 Feb 2024 13:41:10 +0000 (13:41 +0000)
Use the FIELD_PREP() helper, instead open-coding the same operation.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://msgid.link/r/5e8781d31c983caf6bdabe36c5552077422cb8da.1708002575.git.geert+renesas@glider.be
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/lp87565-regulator.c

index 61ee5cf..1259b5d 100644 (file)
@@ -5,6 +5,7 @@
  * Copyright (C) 2017 Texas Instruments Incorporated - https://www.ti.com/
  */
 
+#include <linux/bitfield.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/regmap.h>
@@ -99,7 +100,7 @@ static int lp87565_buck_set_ramp_delay(struct regulator_dev *rdev,
 
        ret = regmap_update_bits(rdev->regmap, regulators[id].ctrl2_reg,
                                 LP87565_BUCK_CTRL_2_SLEW_RATE,
-                                reg << __ffs(LP87565_BUCK_CTRL_2_SLEW_RATE));
+                                FIELD_PREP(LP87565_BUCK_CTRL_2_SLEW_RATE, reg));
        if (ret) {
                dev_err(&rdev->dev, "SLEW RATE write failed: %d\n", ret);
                return ret;