projects
/
linux-2.6-microblaze.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f9cd5f9
)
powerpc/signal32: Fix erroneous SIGSEGV on RT signal return
author
Christophe Leroy
<christophe.leroy@csgroup.eu>
Fri, 23 Apr 2021 13:52:10 +0000
(13:52 +0000)
committer
Michael Ellerman
<mpe@ellerman.id.au>
Wed, 28 Apr 2021 13:35:11 +0000
(23:35 +1000)
Return of user_read_access_begin() is tested the wrong way,
leading to a SIGSEGV when the user address is valid and likely
an Oops when the user address is bad.
Fix the test.
Fixes:
887f3ceb51cd
("powerpc/signal32: Convert do_setcontext[_tm]() to user access block")
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link:
https://lore.kernel.org/r/a29aadc54c93bcbf069a83615fa102ca0f59c3ae.1619185912.git.christophe.leroy@csgroup.eu
arch/powerpc/kernel/signal_32.c
patch
|
blob
|
history
diff --git
a/arch/powerpc/kernel/signal_32.c
b/arch/powerpc/kernel/signal_32.c
index
94442af
..
915ea2a
100644
(file)
--- a/
arch/powerpc/kernel/signal_32.c
+++ b/
arch/powerpc/kernel/signal_32.c
@@
-971,7
+971,7
@@
static int do_setcontext(struct ucontext __user *ucp, struct pt_regs *regs, int
sigset_t set;
struct mcontext __user *mcp;
- if (user_read_access_begin(ucp, sizeof(*ucp)))
+ if (
!
user_read_access_begin(ucp, sizeof(*ucp)))
return -EFAULT;
unsafe_get_sigset_t(&set, &ucp->uc_sigmask, failed);
@@
-1009,7
+1009,7
@@
static int do_setcontext_tm(struct ucontext __user *ucp,
u32 cmcp;
u32 tm_cmcp;
- if (user_read_access_begin(ucp, sizeof(*ucp)))
+ if (
!
user_read_access_begin(ucp, sizeof(*ucp)))
return -EFAULT;
unsafe_get_sigset_t(&set, &ucp->uc_sigmask, failed);