accel/qaic: Order pci_remove() operations in reverse of probe()
authorJeffrey Hugo <quic_jhugo@quicinc.com>
Fri, 8 Dec 2023 16:34:57 +0000 (09:34 -0700)
committerJeffrey Hugo <quic_jhugo@quicinc.com>
Wed, 20 Dec 2023 18:17:57 +0000 (11:17 -0700)
In probe() we create the drm_device, and then register the MHI controller.
In remove(), we should unregister the controller first, then remove the
drm_device.  Update the remove() operations to match.

Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Reviewed-by: Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@quicinc.com>
Reviewed-by: Carl Vanderlip <quic_carlv@quicinc.com>
Reviewed-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231208163457.1295993-8-quic_jhugo@quicinc.com
drivers/accel/qaic/qaic_drv.c

index 10a43d0..d1a632d 100644 (file)
@@ -550,8 +550,8 @@ static void qaic_pci_remove(struct pci_dev *pdev)
                return;
 
        qaic_dev_reset_clean_local_state(qdev);
-       qaic_destroy_drm_device(qdev, QAIC_NO_PARTITION);
        qaic_mhi_free_controller(qdev->mhi_cntrl, link_up);
+       qaic_destroy_drm_device(qdev, QAIC_NO_PARTITION);
 }
 
 static void qaic_pci_shutdown(struct pci_dev *pdev)