drm/i915/dp: Avoid left shift of DSC output bpp by 4
authorAnkit Nautiyal <ankit.k.nautiyal@intel.com>
Thu, 17 Aug 2023 14:24:52 +0000 (19:54 +0530)
committerAnkit Nautiyal <ankit.k.nautiyal@intel.com>
Fri, 18 Aug 2023 04:12:21 +0000 (09:42 +0530)
To make way for fractional bpp support, avoid left shifting the
output_bpp by 4 in helper intel_dp_dsc_get_output_bpp.

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230817142459.89764-12-ankit.k.nautiyal@intel.com
drivers/gpu/drm/i915/display/intel_dp.c
drivers/gpu/drm/i915/display/intel_dp_mst.c

index 52c47e1..60c66cc 100644 (file)
@@ -814,11 +814,7 @@ u16 intel_dp_dsc_get_max_compressed_bpp(struct drm_i915_private *i915,
 
        bits_per_pixel = intel_dp_dsc_nearest_valid_bpp(i915, bits_per_pixel, pipe_bpp);
 
-       /*
-        * Compressed BPP in U6.4 format so multiply by 16, for Gen 11,
-        * fractional part is 0
-        */
-       return bits_per_pixel << 4;
+       return bits_per_pixel;
 }
 
 u8 intel_dp_dsc_get_slice_count(struct intel_dp *intel_dp,
@@ -1208,7 +1204,7 @@ intel_dp_mode_valid(struct drm_connector *_connector,
                                                                    mode->hdisplay,
                                                                    bigjoiner,
                                                                    output_format,
-                                                                   pipe_bpp, 64) >> 4;
+                                                                   pipe_bpp, 64);
                        dsc_slice_count =
                                intel_dp_dsc_get_slice_count(intel_dp,
                                                             target_clock,
@@ -1811,7 +1807,7 @@ int intel_dp_dsc_compute_config(struct intel_dp *intel_dp,
                                                             pipe_config->pipe_bpp);
 
                        pipe_config->dsc.compressed_bpp = min_t(u16,
-                                                               dsc_max_compressed_bpp >> 4,
+                                                               dsc_max_compressed_bpp,
                                                                output_bpp);
                }
                pipe_config->dsc.slice_count = dsc_dp_slice_count;
index dff4717..4895d62 100644 (file)
@@ -982,7 +982,7 @@ intel_dp_mst_mode_valid_ctx(struct drm_connector *connector,
                                                                    mode->hdisplay,
                                                                    bigjoiner,
                                                                    INTEL_OUTPUT_FORMAT_RGB,
-                                                                   pipe_bpp, 64) >> 4;
+                                                                   pipe_bpp, 64);
                        dsc_slice_count =
                                intel_dp_dsc_get_slice_count(intel_dp,
                                                             target_clock,