net: mvpp2: cls: Remove unnessesary check in mvpp2_ethtool_cls_rule_ins
authorYueHaibing <yuehaibing@huawei.com>
Wed, 29 May 2019 02:59:06 +0000 (10:59 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 30 May 2019 18:46:59 +0000 (11:46 -0700)
Fix smatch warning:

drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c:1236
 mvpp2_ethtool_cls_rule_ins() warn: unsigned 'info->fs.location' is never less than zero.

'info->fs.location' is u32 type, never less than zero.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.c

index bd19a91..e1c90ad 100644 (file)
@@ -1300,8 +1300,7 @@ int mvpp2_ethtool_cls_rule_ins(struct mvpp2_port *port,
        struct mvpp2_ethtool_fs *efs, *old_efs;
        int ret = 0;
 
-       if (info->fs.location >= MVPP2_N_RFS_ENTRIES_PER_FLOW ||
-           info->fs.location < 0)
+       if (info->fs.location >= MVPP2_N_RFS_ENTRIES_PER_FLOW)
                return -EINVAL;
 
        efs = kzalloc(sizeof(*efs), GFP_KERNEL);