bus/fsl_mc: Do not rely on caller to provide non NULL mc_io
authorDiana Craciun <diana.craciun@oss.nxp.com>
Tue, 29 Sep 2020 08:54:38 +0000 (11:54 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 2 Oct 2020 14:05:01 +0000 (16:05 +0200)
Before destroying the mc_io, check first that it was
allocated.

Reviewed-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Acked-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Diana Craciun <diana.craciun@oss.nxp.com>
Link: https://lore.kernel.org/r/20200929085441.17448-11-diana.craciun@oss.nxp.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/bus/fsl-mc/mc-io.c

index a30b53f..3050154 100644 (file)
@@ -129,7 +129,12 @@ error_destroy_mc_io:
  */
 void fsl_destroy_mc_io(struct fsl_mc_io *mc_io)
 {
-       struct fsl_mc_device *dpmcp_dev = mc_io->dpmcp_dev;
+       struct fsl_mc_device *dpmcp_dev;
+
+       if (!mc_io)
+               return;
+
+       dpmcp_dev = mc_io->dpmcp_dev;
 
        if (dpmcp_dev)
                fsl_mc_io_unset_dpmcp(mc_io);