mips: Return proper error code from console ->setup() hook
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 18 Jun 2020 16:47:46 +0000 (19:47 +0300)
committerPetr Mladek <pmladek@suse.com>
Thu, 25 Jun 2020 12:20:13 +0000 (14:20 +0200)
For unifying console ->setup() handling, which is poorly documented,
return error code, rather than non-zero arbitrary number.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20200618164751.56828-2-andriy.shevchenko@linux.intel.com
arch/mips/fw/arc/arc_con.c

index 365e391..7fdce23 100644 (file)
@@ -28,7 +28,9 @@ static void prom_console_write(struct console *co, const char *s,
 
 static int prom_console_setup(struct console *co, char *options)
 {
-       return !(prom_flags & PROM_FLAG_USE_AS_CONSOLE);
+       if (prom_flags & PROM_FLAG_USE_AS_CONSOLE)
+               return 0;
+       return -ENODEV;
 }
 
 static struct console arc_cons = {