drm/bridge: ti-sn65dsi86: Reorder remove()
authorDouglas Anderson <dianders@chromium.org>
Fri, 16 Apr 2021 22:39:27 +0000 (15:39 -0700)
committerDouglas Anderson <dianders@chromium.org>
Tue, 20 Apr 2021 15:58:15 +0000 (08:58 -0700)
Let's make the remove() function strictly the reverse of the probe()
function so it's easier to reason about.

This patch was created by code inspection and should move us closer to
a proper remove.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210416153909.v4.4.Ifcf1deaa372eba7eeb4f8eb516c5d15b77a657a9@changeid
drivers/gpu/drm/bridge/ti-sn65dsi86.c

index 76f43af..c006678 100644 (file)
@@ -1315,20 +1315,21 @@ static int ti_sn_bridge_remove(struct i2c_client *client)
        if (!pdata)
                return -EINVAL;
 
-       kfree(pdata->edid);
-       ti_sn_debugfs_remove(pdata);
-
-       of_node_put(pdata->host_node);
-
-       pm_runtime_disable(pdata->dev);
-
        if (pdata->dsi) {
                mipi_dsi_detach(pdata->dsi);
                mipi_dsi_device_unregister(pdata->dsi);
        }
 
+       kfree(pdata->edid);
+
+       ti_sn_debugfs_remove(pdata);
+
        drm_bridge_remove(&pdata->bridge);
 
+       pm_runtime_disable(pdata->dev);
+
+       of_node_put(pdata->host_node);
+
        return 0;
 }