sctp: pass a kernel pointer to sctp_setsockopt_add_streams

Use the kernel pointer that sctp_setsockopt has available instead of
directly handling the user pointer.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index f190f59..4dedb94 100644 (file)
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -4099,29 +4099,19 @@ static int sctp_setsockopt_reset_assoc(struct sock *sk, sctp_assoc_t *associd,
 }
 
 static int sctp_setsockopt_add_streams(struct sock *sk,
-                                      char __user *optval,
+                                      struct sctp_add_streams *params,
                                       unsigned int optlen)
 {
        struct sctp_association *asoc;
-       struct sctp_add_streams params;
-       int retval = -EINVAL;
-
-       if (optlen != sizeof(params))
-               goto out;
 
-       if (copy_from_user(&params, optval, optlen)) {
-               retval = -EFAULT;
-               goto out;
-       }
+       if (optlen != sizeof(*params))
+               return -EINVAL;
 
-       asoc = sctp_id2assoc(sk, params.sas_assoc_id);
+       asoc = sctp_id2assoc(sk, params->sas_assoc_id);
        if (!asoc)
-               goto out;
-
-       retval = sctp_send_add_streams(asoc, &params);
+               return -EINVAL;
 
-out:
-       return retval;
+       return sctp_send_add_streams(asoc, params);
 }
 
 static int sctp_setsockopt_scheduler(struct sock *sk,
@@ -4667,7 +4657,7 @@ static int sctp_setsockopt(struct sock *sk, int level, int optname,
                retval = sctp_setsockopt_reset_assoc(sk, kopt, optlen);
                break;
        case SCTP_ADD_STREAMS:
-               retval = sctp_setsockopt_add_streams(sk, optval, optlen);
+               retval = sctp_setsockopt_add_streams(sk, kopt, optlen);
                break;
        case SCTP_STREAM_SCHEDULER:
                retval = sctp_setsockopt_scheduler(sk, optval, optlen);