ASoC: codecs: lpass-va-macro: remove some dead code
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 2 Dec 2020 06:51:46 +0000 (09:51 +0300)
committerMark Brown <broonie@kernel.org>
Wed, 2 Dec 2020 15:18:23 +0000 (15:18 +0000)
The "decimator" variable is in the 0-7 range and it's unsigned so there
is no need to check for negative values.

Fixes: 908e6b1df26e ("ASoC: codecs: lpass-va-macro: Add support to VA Macro")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/X8c5gjZO7YN/CFsq@mwanda
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/lpass-va-macro.c

index 3e6bbef..91e6890 100644 (file)
@@ -844,17 +844,10 @@ static int va_macro_hw_params(struct snd_pcm_substream *substream,
 
        for_each_set_bit(decimator, &va->active_ch_mask[dai->id],
                         VA_MACRO_DEC_MAX) {
-               if (decimator >= 0) {
-                       tx_fs_reg = CDC_VA_TX0_TX_PATH_CTL +
-                                   VA_MACRO_TX_PATH_OFFSET * decimator;
-                       snd_soc_component_update_bits(component, tx_fs_reg,
-                                               0x0F, tx_fs_rate);
-               } else {
-                       dev_err(va_dev,
-                               "%s: ERROR: Invalid decimator: %d\n",
-                               __func__, decimator);
-                       return -EINVAL;
-               }
+               tx_fs_reg = CDC_VA_TX0_TX_PATH_CTL +
+                           VA_MACRO_TX_PATH_OFFSET * decimator;
+               snd_soc_component_update_bits(component, tx_fs_reg, 0x0F,
+                                             tx_fs_rate);
        }
        return 0;
 }