platform/x86: int3472: Debug log when remapping pins
authorHans de Goede <hdegoede@redhat.com>
Thu, 17 Apr 2025 11:13:37 +0000 (13:13 +0200)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Thu, 24 Apr 2025 13:05:42 +0000 (16:05 +0300)
Debug log when remapping a pin/function because of a int3472_gpio_map[]
match.

Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Tested-by: David Heidelberg <david@ixit.cz> # Dell Latitude 9440
Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Link: https://lore.kernel.org/r/20250417111337.38142-10-hdegoede@redhat.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/intel/int3472/discrete.c

index bcc7bb1..394975f 100644 (file)
@@ -146,9 +146,10 @@ static const struct int3472_gpio_map int3472_gpio_map[] = {
        { "INT347E", INT3472_GPIO_TYPE_RESET, INT3472_GPIO_TYPE_RESET, false, "enable" },
 };
 
-static void int3472_get_con_id_and_polarity(struct acpi_device *adev, u8 *type,
+static void int3472_get_con_id_and_polarity(struct int3472_discrete_device *int3472, u8 *type,
                                            const char **con_id, unsigned long *gpio_flags)
 {
+       struct acpi_device *adev = int3472->sensor;
        unsigned int i;
 
        for (i = 0; i < ARRAY_SIZE(int3472_gpio_map); i++) {
@@ -163,6 +164,9 @@ static void int3472_get_con_id_and_polarity(struct acpi_device *adev, u8 *type,
                if (!acpi_dev_hid_uid_match(adev, int3472_gpio_map[i].hid, NULL))
                        continue;
 
+               dev_dbg(int3472->dev, "mapping type 0x%02x pin to 0x%02x %s\n",
+                       *type, int3472_gpio_map[i].type_to, int3472_gpio_map[i].con_id);
+
                *type = int3472_gpio_map[i].type_to;
                *gpio_flags = int3472_gpio_map[i].polarity_low ?
                              GPIO_ACTIVE_LOW : GPIO_ACTIVE_HIGH;
@@ -267,7 +271,7 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares,
 
        type = FIELD_GET(INT3472_GPIO_DSM_TYPE, obj->integer.value);
 
-       int3472_get_con_id_and_polarity(int3472->sensor, &type, &con_id, &gpio_flags);
+       int3472_get_con_id_and_polarity(int3472, &type, &con_id, &gpio_flags);
 
        pin = FIELD_GET(INT3472_GPIO_DSM_PIN, obj->integer.value);
        /* Pin field is not really used under Windows and wraps around at 8 bits */