r8169: remove not needed PHY soft reset in rtl8168e_2_hw_phy_config
authorHeiner Kallweit <hkallweit1@gmail.com>
Tue, 20 Feb 2018 06:30:16 +0000 (07:30 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 21 Feb 2018 18:16:14 +0000 (13:16 -0500)
rtl8169_init_phy() resets the PHY anyway after applying the chip-specific
PHY configuration. So we don't need to soft-reset the PHY as part of the
chip-specific configuration.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/r8169.c

index 2f3e3ae..c16b97a 100644 (file)
@@ -3800,8 +3800,6 @@ static void rtl8168e_2_hw_phy_config(struct rtl8169_private *tp)
        rtl_writephy(tp, 0x1f, 0x0005);
        rtl_w0w1_phy(tp, 0x01, 0x0100, 0x0000);
        rtl_writephy(tp, 0x1f, 0x0000);
-       /* soft-reset phy */
-       rtl_writephy(tp, MII_BMCR, BMCR_RESET | BMCR_ANENABLE | BMCR_ANRESTART);
 
        /* Broken BIOS workaround: feed GigaMAC registers with MAC address. */
        rtl_rar_exgmac_set(tp, tp->dev->dev_addr);