Revert "net: sched: bump refcount for new action in ACT replace mode"
authorVlad Buslov <vladbu@nvidia.com>
Wed, 7 Apr 2021 15:36:02 +0000 (18:36 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 8 Apr 2021 20:47:33 +0000 (13:47 -0700)
This reverts commit 6855e8213e06efcaf7c02a15e12b1ae64b9a7149.

Following commit in series fixes the issue without introducing regression
in error rollback of tcf_action_destroy().

Signed-off-by: Vlad Buslov <vladbu@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/act_api.c

index 43cceb9..b919826 100644 (file)
@@ -1042,9 +1042,6 @@ struct tc_action *tcf_action_init_1(struct net *net, struct tcf_proto *tp,
        if (err != ACT_P_CREATED)
                module_put(a_o->owner);
 
-       if (!bind && ovr && err == ACT_P_CREATED)
-               refcount_set(&a->tcfa_refcnt, 2);
-
        return a;
 
 err_out: