drm/imagination: move update_logtype() into ifdef section
authorArnd Bergmann <arnd@arndb.de>
Mon, 4 Dec 2023 07:32:10 +0000 (08:32 +0100)
committerMaxime Ripard <mripard@kernel.org>
Wed, 6 Dec 2023 13:07:50 +0000 (14:07 +0100)
This function is only used when debugfs is enabled, and otherwise
causes a build warning:

drivers/gpu/drm/imagination/pvr_fw_trace.c:135:1: error: 'update_logtype' defined but not used [-Werror=unused-function]

Move the #ifdef check to include this function as well.

Fixes: cb56cd610866 ("drm/imagination: Add firmware trace to debugfs")
Acked-by: Frank Binns <frank.binns@imgtec.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20231204073231.1164163-1-arnd@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>
drivers/gpu/drm/imagination/pvr_fw_trace.c

index 30f41a1..7159fc4 100644 (file)
@@ -121,6 +121,8 @@ void pvr_fw_trace_fini(struct pvr_device *pvr_dev)
        pvr_fw_object_unmap_and_destroy(fw_trace->tracebuf_ctrl_obj);
 }
 
+#if defined(CONFIG_DEBUG_FS)
+
 /**
  * update_logtype() - Send KCCB command to trigger FW to update logtype
  * @pvr_dev: Target PowerVR device
@@ -165,8 +167,6 @@ err_up_read:
        return err;
 }
 
-#if defined(CONFIG_DEBUG_FS)
-
 struct pvr_fw_trace_seq_data {
        /** @buffer: Pointer to copy of trace data. */
        u32 *buffer;