drm/amd/display: Add debugging message for brightness caps
authorMario Limonciello <mario.limonciello@amd.com>
Wed, 14 May 2025 21:00:43 +0000 (16:00 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 3 Jun 2025 19:33:31 +0000 (15:33 -0400)
[Why]
Default BIOS brightness caps are buried in ACPI.

[How]
Add extra dynamic debug that can show default brightness caps.

Reviewed-by: Alex Hung <alex.hung@amd.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Wayne Lin <wayne.lin@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

index 1797fa8..588f6af 100644 (file)
@@ -4910,6 +4910,7 @@ amdgpu_dm_register_backlight_device(struct amdgpu_dm_connector *aconnector)
        struct backlight_properties props = { 0 };
        struct amdgpu_dm_backlight_caps caps = { 0 };
        char bl_name[16];
+       int min, max;
 
        if (aconnector->bl_idx == -1)
                return;
@@ -4922,11 +4923,15 @@ amdgpu_dm_register_backlight_device(struct amdgpu_dm_connector *aconnector)
        }
 
        amdgpu_acpi_get_backlight_caps(&caps);
-       if (caps.caps_valid) {
+       if (caps.caps_valid && get_brightness_range(&caps, &min, &max)) {
                if (power_supply_is_system_supplied() > 0)
                        props.brightness = caps.ac_level;
                else
                        props.brightness = caps.dc_level;
+               /* min is zero, so max needs to be adjusted */
+               props.max_brightness = max - min;
+               drm_dbg(drm, "Backlight caps: min: %d, max: %d, ac %d, dc %d\n", min, max,
+                       caps.ac_level, caps.dc_level);
        } else
                props.brightness = AMDGPU_MAX_BL_LEVEL;