net: phylink: Add phylink_set_fixed_link() to configure fixed link state in phylink
authorRussell King <linux@armlinux.org.uk>
Fri, 6 Sep 2024 10:35:07 +0000 (16:05 +0530)
committerDavid S. Miller <davem@davemloft.net>
Wed, 11 Sep 2024 10:06:11 +0000 (11:06 +0100)
The function allows for the configuration of a fixed link state for a given
phylink instance. This addition is particularly useful for network devices that
operate with a fixed link configuration, where the link parameters do not change
dynamically. By using `phylink_set_fixed_link()`, drivers can easily set up
the fixed link state during initialization or configuration changes.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Russell King <linux@armlinux.org.uk>
Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phylink.c
include/linux/phylink.h

index ab4e9fc..4309317 100644 (file)
@@ -1635,6 +1635,48 @@ static int phylink_register_sfp(struct phylink *pl,
        return ret;
 }
 
+/**
+ * phylink_set_fixed_link() - set the fixed link
+ * @pl: a pointer to a &struct phylink returned from phylink_create()
+ * @state: a pointer to a struct phylink_link_state.
+ *
+ * This function is used when the link parameters are known and do not change,
+ * making it suitable for certain types of network connections.
+ *
+ * Returns: zero on success or negative error code.
+ */
+int phylink_set_fixed_link(struct phylink *pl,
+                          const struct phylink_link_state *state)
+{
+       const struct phy_setting *s;
+       unsigned long *adv;
+
+       if (pl->cfg_link_an_mode != MLO_AN_PHY || !state ||
+           !test_bit(PHYLINK_DISABLE_STOPPED, &pl->phylink_disable_state))
+               return -EINVAL;
+
+       s = phy_lookup_setting(state->speed, state->duplex,
+                              pl->supported, true);
+       if (!s)
+               return -EINVAL;
+
+       adv = pl->link_config.advertising;
+       linkmode_zero(adv);
+       linkmode_set_bit(s->bit, adv);
+       linkmode_set_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, adv);
+
+       pl->link_config.speed = state->speed;
+       pl->link_config.duplex = state->duplex;
+       pl->link_config.link = 1;
+       pl->link_config.an_complete = 1;
+
+       pl->cfg_link_an_mode = MLO_AN_FIXED;
+       pl->cur_link_an_mode = pl->cfg_link_an_mode;
+
+       return 0;
+}
+EXPORT_SYMBOL_GPL(phylink_set_fixed_link);
+
 /**
  * phylink_create() - create a phylink instance
  * @config: a pointer to the target &struct phylink_config
index 2381e07..5c01048 100644 (file)
@@ -598,6 +598,8 @@ int phylink_fwnode_phy_connect(struct phylink *pl,
                               const struct fwnode_handle *fwnode,
                               u32 flags);
 void phylink_disconnect_phy(struct phylink *);
+int phylink_set_fixed_link(struct phylink *,
+                          const struct phylink_link_state *);
 
 void phylink_mac_change(struct phylink *, bool up);
 void phylink_pcs_change(struct phylink_pcs *, bool up);