projects
/
linux-2.6-microblaze.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
c0a2a1b
)
Revert "ptp: Fixes a null pointer dereference in ptp_ioctl"
author
Jakub Kicinski
<kuba@kernel.org>
Tue, 14 Nov 2023 04:49:39 +0000
(20:49 -0800)
committer
Jakub Kicinski
<kuba@kernel.org>
Tue, 14 Nov 2023 04:50:12 +0000
(20:50 -0800)
This reverts commit
8a4f030dbced6fc255cbe67b2d0a129947e18493
.
Richard says:
The test itself is harmless, but keeping it will make people think,
"oh this pointer can be invalid."
In fact the core stack ensures that ioctl() can't be invoked after
release(), otherwise Bad Stuff happens.
Fixes:
8a4f030dbced
("ptp: Fixes a null pointer dereference in ptp_ioctl")
Link:
https://lore.kernel.org/all/ZVAf_qdRfDAQYUt-@hoboy.vegasvil.org/
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/ptp/ptp_chardev.c
patch
|
blob
|
history
diff --git
a/drivers/ptp/ptp_chardev.c
b/drivers/ptp/ptp_chardev.c
index
e95a6ed
..
3f7a747
100644
(file)
--- a/
drivers/ptp/ptp_chardev.c
+++ b/
drivers/ptp/ptp_chardev.c
@@
-176,8
+176,6
@@
long ptp_ioctl(struct posix_clock_context *pccontext, unsigned int cmd,
int enable, err = 0;
tsevq = pccontext->private_clkdata;
- if (!tsevq)
- return -EINVAL;
switch (cmd) {