blk-mq: never redirect polled IO completions
authorJens Axboe <axboe@kernel.dk>
Sun, 18 Nov 2018 23:15:35 +0000 (16:15 -0700)
committerJens Axboe <axboe@kernel.dk>
Mon, 26 Nov 2018 15:26:04 +0000 (08:26 -0700)
It's pointless to do so, we are by definition on the CPU we want/need
to be, as that's the one waiting for a completion event.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq.c

index ba3c7b6..37674c1 100644 (file)
@@ -585,7 +585,12 @@ static void __blk_mq_complete_request(struct request *rq)
                return;
        }
 
-       if (!test_bit(QUEUE_FLAG_SAME_COMP, &q->queue_flags)) {
+       /*
+        * For a polled request, always complete locallly, it's pointless
+        * to redirect the completion.
+        */
+       if ((rq->cmd_flags & REQ_HIPRI) ||
+           !test_bit(QUEUE_FLAG_SAME_COMP, &q->queue_flags)) {
                q->mq_ops->complete(rq);
                return;
        }