scsi: mpt3sas: Remove superfluous memset()
authorLi Heng <liheng40@huawei.com>
Thu, 30 Jul 2020 03:31:58 +0000 (11:31 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 21 Aug 2020 03:25:49 +0000 (23:25 -0400)
Fixes coccicheck warning:

./drivers/scsi/mpt3sas/mpt3sas_base.c:5247:16-34: WARNING: dma_alloc_coherent use in ioc -> request already zeroes out memory,  so memset is not needed

dma_alloc_coherent() already zeroes out memory so memset() is not needed.

Link: https://lore.kernel.org/r/1596079918-41115-4-git-send-email-liheng40@huawei.com
Signed-off-by: Li Heng <liheng40@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/mpt3sas/mpt3sas_base.c

index 53a835b..4aae441 100644 (file)
@@ -5259,7 +5259,6 @@ _base_allocate_memory_pools(struct MPT3SAS_ADAPTER *ioc)
                _base_release_memory_pools(ioc);
                goto retry_allocation;
        }
-       memset(ioc->request, 0, sz);
 
        if (retry_sz)
                ioc_err(ioc, "request pool: dma_alloc_coherent succeed: hba_depth(%d), chains_per_io(%d), frame_sz(%d), total(%d kb)\n",