selftests/bpf: Drop duplicate bpf_map_lookup_elem in test_sockmap
authorGeliang Tang <tanggeliang@kylinos.cn>
Thu, 23 May 2024 06:50:04 +0000 (14:50 +0800)
committerDaniel Borkmann <daniel@iogearbox.net>
Mon, 3 Jun 2024 17:32:55 +0000 (19:32 +0200)
bpf_map_lookup_elem is invoked in bpf_prog3() already, no need to invoke
it again. This patch drops it.

Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Tested-by: Jakub Sitnicki <jakub@cloudflare.com>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Link: https://lore.kernel.org/bpf/ea8458462b876ee445173e3effb535fd126137ed.1716446893.git.tanggeliang@kylinos.cn
tools/testing/selftests/bpf/progs/test_sockmap_kern.h

index 3dff081..f48f85f 100644 (file)
@@ -177,9 +177,6 @@ int bpf_prog3(struct __sk_buff *skb)
                return bpf_sk_redirect_hash(skb, &tls_sock_map, &ret, flags);
 #endif
        }
-       f = bpf_map_lookup_elem(&sock_skb_opts, &one);
-       if (f && *f)
-               ret = SK_DROP;
        err = bpf_skb_adjust_room(skb, 4, 0, 0);
        if (err)
                return SK_DROP;