net: remove IFF_* re-definition
authorJakub Kicinski <kuba@kernel.org>
Thu, 1 Aug 2024 16:34:01 +0000 (09:34 -0700)
committerJakub Kicinski <kuba@kernel.org>
Fri, 2 Aug 2024 23:03:51 +0000 (16:03 -0700)
We re-define values of enum netdev_priv_flags as preprocessor
macros with the same name. I guess this was done to avoid breaking
out of tree modules which may use #ifdef X for kernel compatibility?
Commit 7aa98047df95 ("net: move net_device priv_flags out from UAPI")
which added the enum doesn't say. In any case, the flags with defines
are quite old now, and defines for new flags don't get added.
OOT drivers have to resort to code greps for compat detection, anyway.
Let's delete these defines, save LoC, help LXR link to the right place.

Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Link: https://patch.msgid.link/20240801163401.378723-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/linux/netdevice.h

index 6070091..0ef3eaa 100644 (file)
@@ -1689,38 +1689,6 @@ enum netdev_priv_flags {
        IFF_SEE_ALL_HWTSTAMP_REQUESTS   = BIT_ULL(33),
 };
 
-#define IFF_802_1Q_VLAN                        IFF_802_1Q_VLAN
-#define IFF_EBRIDGE                    IFF_EBRIDGE
-#define IFF_BONDING                    IFF_BONDING
-#define IFF_ISATAP                     IFF_ISATAP
-#define IFF_WAN_HDLC                   IFF_WAN_HDLC
-#define IFF_XMIT_DST_RELEASE           IFF_XMIT_DST_RELEASE
-#define IFF_DONT_BRIDGE                        IFF_DONT_BRIDGE
-#define IFF_DISABLE_NETPOLL            IFF_DISABLE_NETPOLL
-#define IFF_MACVLAN_PORT               IFF_MACVLAN_PORT
-#define IFF_BRIDGE_PORT                        IFF_BRIDGE_PORT
-#define IFF_OVS_DATAPATH               IFF_OVS_DATAPATH
-#define IFF_TX_SKB_SHARING             IFF_TX_SKB_SHARING
-#define IFF_UNICAST_FLT                        IFF_UNICAST_FLT
-#define IFF_TEAM_PORT                  IFF_TEAM_PORT
-#define IFF_SUPP_NOFCS                 IFF_SUPP_NOFCS
-#define IFF_LIVE_ADDR_CHANGE           IFF_LIVE_ADDR_CHANGE
-#define IFF_MACVLAN                    IFF_MACVLAN
-#define IFF_XMIT_DST_RELEASE_PERM      IFF_XMIT_DST_RELEASE_PERM
-#define IFF_L3MDEV_MASTER              IFF_L3MDEV_MASTER
-#define IFF_NO_QUEUE                   IFF_NO_QUEUE
-#define IFF_OPENVSWITCH                        IFF_OPENVSWITCH
-#define IFF_L3MDEV_SLAVE               IFF_L3MDEV_SLAVE
-#define IFF_TEAM                       IFF_TEAM
-#define IFF_RXFH_CONFIGURED            IFF_RXFH_CONFIGURED
-#define IFF_PHONY_HEADROOM             IFF_PHONY_HEADROOM
-#define IFF_MACSEC                     IFF_MACSEC
-#define IFF_NO_RX_HANDLER              IFF_NO_RX_HANDLER
-#define IFF_FAILOVER                   IFF_FAILOVER
-#define IFF_FAILOVER_SLAVE             IFF_FAILOVER_SLAVE
-#define IFF_L3MDEV_RX_HANDLER          IFF_L3MDEV_RX_HANDLER
-#define IFF_TX_SKB_NO_LINEAR           IFF_TX_SKB_NO_LINEAR
-
 /* Specifies the type of the struct net_device::ml_priv pointer */
 enum netdev_ml_priv_type {
        ML_PRIV_NONE,