platform/x86: dell-pc: Use non-atomic bitmap operations
authorKurt Borja <kuurtb@gmail.com>
Fri, 11 Apr 2025 14:36:42 +0000 (11:36 -0300)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Thu, 24 Apr 2025 12:51:52 +0000 (15:51 +0300)
The choices bitmap belongs only to this thread, therefore we can use the
non-atomic version of set_bit().

Signed-off-by: Kurt Borja <kuurtb@gmail.com>
Link: https://lore.kernel.org/r/20250411-dell-faux-v1-2-ea1f1c929b7e@gmail.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/dell/dell-pc.c

index 38f198a..7949249 100644 (file)
@@ -11,6 +11,7 @@
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 
 #include <linux/bitfield.h>
+#include <linux/bitops.h>
 #include <linux/bits.h>
 #include <linux/dmi.h>
 #include <linux/err.h>
@@ -228,13 +229,13 @@ static int thermal_platform_profile_get(struct device *dev,
 static int thermal_platform_profile_probe(void *drvdata, unsigned long *choices)
 {
        if (supported_modes & DELL_QUIET)
-               set_bit(PLATFORM_PROFILE_QUIET, choices);
+               __set_bit(PLATFORM_PROFILE_QUIET, choices);
        if (supported_modes & DELL_COOL_BOTTOM)
-               set_bit(PLATFORM_PROFILE_COOL, choices);
+               __set_bit(PLATFORM_PROFILE_COOL, choices);
        if (supported_modes & DELL_BALANCED)
-               set_bit(PLATFORM_PROFILE_BALANCED, choices);
+               __set_bit(PLATFORM_PROFILE_BALANCED, choices);
        if (supported_modes & DELL_PERFORMANCE)
-               set_bit(PLATFORM_PROFILE_PERFORMANCE, choices);
+               __set_bit(PLATFORM_PROFILE_PERFORMANCE, choices);
 
        return 0;
 }