Input: alps - remove redundant assignment to variable ret
authorColin Ian King <colin.king@canonical.com>
Thu, 6 Aug 2020 22:35:17 +0000 (15:35 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 7 Aug 2020 00:33:41 +0000 (17:33 -0700)
The variable ret is being initialized with a value that is
never read and it is being updated later with a new value. The
initialization is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20200603135742.130852-1-colin.king@canonical.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/mouse/alps.c

index 34700ed..b067bfd 100644 (file)
@@ -1929,7 +1929,7 @@ static int alps_monitor_mode(struct psmouse *psmouse, bool enable)
 static int alps_absolute_mode_v6(struct psmouse *psmouse)
 {
        u16 reg_val = 0x181;
-       int ret = -1;
+       int ret;
 
        /* enter monitor mode, to write the register */
        if (alps_monitor_mode(psmouse, true))