staging: vchiq: Don't use a typedef for vchiq_callback

Linux coding style says to avoid typdefs.

Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Link: https://lore.kernel.org/r/20200629150945.10720-30-nsaenzjulienne@suse.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h b/drivers/staging/vc04_services/interface/vchi/vchi.h
index fdc243f..cb66ea1 100644 (file)
--- a/drivers/staging/vc04_services/interface/vchi/vchi.h
+++ b/drivers/staging/vc04_services/interface/vchi/vchi.h
@@ -35,7 +35,10 @@ struct vchi_service {
 struct service_creation {
        struct vchi_version version;
        int32_t service_id;
-       vchiq_callback callback;
+       enum vchiq_status (*callback)(enum vchiq_reason reason,
+                                     struct vchiq_header *header,
+                                     unsigned int handle,
+                                     void *bulk_userdata);
        void *callback_param;
 };
 

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h
index c99caa3..b3d4c14 100644 (file)
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_if.h
@@ -60,19 +60,21 @@ struct vchiq_element {
        unsigned int size;
 };
 
-typedef enum vchiq_status (*vchiq_callback)(enum vchiq_reason,
-                                           struct vchiq_header *,
-                                           unsigned int, void *);
-
 struct vchiq_service_base {
        int fourcc;
-       vchiq_callback callback;
+       enum vchiq_status (*callback)(enum vchiq_reason reason,
+                                     struct vchiq_header *header,
+                                     unsigned int handle,
+                                     void *bulk_userdata);
        void *userdata;
 };
 
 struct vchiq_service_params {
        int fourcc;
-       vchiq_callback callback;
+       enum vchiq_status (*callback)(enum vchiq_reason reason,
+                                     struct vchiq_header *header,
+                                     unsigned int handle,
+                                     void *bulk_userdata);
        void *userdata;
        short version;       /* Increment for non-trivial changes */
        short version_min;   /* Update for incompatible changes */