[media] drivers/media/rc: postpone kfree(rc_dev)
authorMax Kellermann <max@duempel.org>
Mon, 21 Mar 2016 11:33:05 +0000 (08:33 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Sat, 7 May 2016 14:21:04 +0000 (11:21 -0300)
CONFIG_DEBUG_KOBJECT_RELEASE found this bug.

Signed-off-by: Max Kellermann <max@duempel.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/rc/rc-main.c

index 68541b1..7dfc7c2 100644 (file)
@@ -1263,6 +1263,9 @@ unlock:
 
 static void rc_dev_release(struct device *device)
 {
+       struct rc_dev *dev = to_rc_dev(device);
+
+       kfree(dev);
 }
 
 #define ADD_HOTPLUG_VAR(fmt, val...)                                   \
@@ -1384,7 +1387,9 @@ void rc_free_device(struct rc_dev *dev)
 
        put_device(&dev->dev);
 
-       kfree(dev);
+       /* kfree(dev) will be called by the callback function
+          rc_dev_release() */
+
        module_put(THIS_MODULE);
 }
 EXPORT_SYMBOL_GPL(rc_free_device);