tools/firewire: Fix several incorrect format specifiers
authorLuo Yifan <luoyifan@cmss.chinamobile.com>
Wed, 13 Nov 2024 02:31:37 +0000 (10:31 +0800)
committerTakashi Sakamoto <o-takashi@sakamocchi.jp>
Thu, 14 Nov 2024 00:12:04 +0000 (09:12 +0900)
Make a minor change to eliminate static checker warnings. Fix several
incorrect format specifiers that misused signed and unsigned versions.

Signed-off-by: Luo Yifan <luoyifan@cmss.chinamobile.com>
Link: https://lore.kernel.org/r/20241113023137.291661-1-luoyifan@cmss.chinamobile.com
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
tools/firewire/decode-fcp.c
tools/firewire/nosy-dump.c

index b67ebc8..f115a3b 100644 (file)
@@ -160,7 +160,7 @@ decode_avc(struct link_transaction *t)
                name = info->name;
        }
 
-       printf("av/c %s, subunit_type=%s, subunit_id=%d, opcode=%s",
+       printf("av/c %s, subunit_type=%s, subunit_id=%u, opcode=%s",
            ctype_names[frame->ctype], subunit_type_names[frame->subunit_type],
            frame->subunit_id, name);
 
index 156e035..9a906de 100644 (file)
@@ -771,7 +771,7 @@ print_packet(uint32_t *data, size_t length)
                                if (pp->phy_config.set_root)
                                        printf(" set_root_id=%02x", pp->phy_config.root_id);
                                if (pp->phy_config.set_gap_count)
-                                       printf(" set_gap_count=%d", pp->phy_config.gap_count);
+                                       printf(" set_gap_count=%u", pp->phy_config.gap_count);
                        }
                        break;
 
@@ -781,13 +781,13 @@ print_packet(uint32_t *data, size_t length)
 
                case PHY_PACKET_SELF_ID:
                        if (pp->self_id.extended) {
-                               printf("extended self id: phy_id=%02x, seq=%d",
+                               printf("extended self id: phy_id=%02x, seq=%u",
                                       pp->ext_self_id.phy_id, pp->ext_self_id.sequence);
                        } else {
                                static const char * const speed_names[] = {
                                        "S100", "S200", "S400", "BETA"
                                };
-                               printf("self id: phy_id=%02x, link %s, gap_count=%d, speed=%s%s%s",
+                               printf("self id: phy_id=%02x, link %s, gap_count=%u speed=%s%s%s",
                                       pp->self_id.phy_id,
                                       (pp->self_id.link_active ? "active" : "not active"),
                                       pp->self_id.gap_count,