net: phy: qca807x: Drop unnecessary and broken DT validation
authorRob Herring (Arm) <robh@kernel.org>
Wed, 31 Jul 2024 20:17:03 +0000 (14:17 -0600)
committerJakub Kicinski <kuba@kernel.org>
Fri, 2 Aug 2024 01:12:42 +0000 (18:12 -0700)
The check for "leds" and "gpio-controller" both being present is never
true because "leds" is a node, not a property. This could be fixed
with a check for child node, but there's really no need for the kernel
to validate a DT. Just continue ignoring the LEDs if GPIOs are present.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://patch.msgid.link/20240731201703.1842022-2-robh@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/qcom/qca807x.c

index 672c692..ba55848 100644 (file)
@@ -733,16 +733,6 @@ static int qca807x_probe(struct phy_device *phydev)
                                                                     "qcom,dac-disable-bias-current-tweak");
 
 #if IS_ENABLED(CONFIG_GPIOLIB)
-       /* Make sure we don't have mixed leds node and gpio-controller
-        * to prevent registering leds and having gpio-controller usage
-        * conflicting with them.
-        */
-       if (of_find_property(node, "leds", NULL) &&
-           of_find_property(node, "gpio-controller", NULL)) {
-               phydev_err(phydev, "Invalid property detected. LEDs and gpio-controller are mutually exclusive.");
-               return -EINVAL;
-       }
-
        /* Do not register a GPIO controller unless flagged for it */
        if (of_property_read_bool(node, "gpio-controller")) {
                ret = qca807x_gpio(phydev);