btrfs: ref-verify: fix memory leak in btrfs_ref_tree_mod
authorDinghao Liu <dinghao.liu@zju.edu.cn>
Wed, 21 Oct 2020 05:36:55 +0000 (13:36 +0800)
committerDavid Sterba <dsterba@suse.com>
Thu, 5 Nov 2020 12:03:39 +0000 (13:03 +0100)
There is one error handling path that does not free ref, which may cause
a minor memory leak.

CC: stable@vger.kernel.org # 4.19+
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/ref-verify.c

index 7f03dbe..78693d3 100644 (file)
@@ -860,6 +860,7 @@ int btrfs_ref_tree_mod(struct btrfs_fs_info *fs_info,
 "dropping a ref for a root that doesn't have a ref on the block");
                        dump_block_entry(fs_info, be);
                        dump_ref_action(fs_info, ra);
+                       kfree(ref);
                        kfree(ra);
                        goto out_unlock;
                }