net: tcp: Remove redundant initialization of variable len
authorColin Ian King <colin.i.king@gmail.com>
Fri, 16 Feb 2024 12:54:43 +0000 (12:54 +0000)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 20 Feb 2024 10:40:15 +0000 (11:40 +0100)
The variable len being initialized with a value that is never read, an
if statement is initializing it in both paths of the if statement.
The initialization is redundant and can be removed.

Cleans up clang scan build warning:
net/ipv4/tcp_ao.c:512:11: warning: Value stored to 'len' during its
initialization is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Dmitry Safonov <0x7f454c46@gmail.com>
Link: https://lore.kernel.org/r/20240216125443.2107244-1-colin.i.king@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/ipv4/tcp_ao.c

index 87db432..3afeeb6 100644 (file)
@@ -509,9 +509,9 @@ static int tcp_ao_hash_header(struct tcp_sigpool *hp,
                              bool exclude_options, u8 *hash,
                              int hash_offset, int hash_len)
 {
-       int err, len = th->doff << 2;
        struct scatterlist sg;
        u8 *hdr = hp->scratch;
+       int err, len;
 
        /* We are not allowed to change tcphdr, make a local copy */
        if (exclude_options) {