platform/x86: dell-pc: Propagate errors when detecting feature support

The dell-pc module only supports the thermal management Dell SMBIOS
feature, therefore it is pointless to have it loaded if this is not
available.

Signed-off-by: Kurt Borja <kuurtb@gmail.com>
Link: https://lore.kernel.org/r/20250411-dell-faux-v1-1-ea1f1c929b7e@gmail.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

diff --git a/drivers/platform/x86/dell/dell-pc.c b/drivers/platform/x86/dell/dell-pc.c
index 483240b..38f198a 100644 (file)
--- a/drivers/platform/x86/dell/dell-pc.c
+++ b/drivers/platform/x86/dell/dell-pc.c
@@ -146,11 +146,6 @@ static int thermal_get_supported_modes(int *supported_bits)
 
        dell_fill_request(&buffer, 0x0, 0, 0, 0);
        ret = dell_send_request(&buffer, CLASS_INFO, SELECT_THERMAL_MANAGEMENT);
-       /* Thermal function not supported */
-       if (ret == -ENXIO) {
-               *supported_bits = 0;
-               return 0;
-       }
        if (ret)
                return ret;
        *supported_bits = FIELD_GET(DELL_THERMAL_SUPPORTED, buffer.output[1]);
@@ -255,16 +250,12 @@ static int thermal_init(void)
        struct device *ppdev;
        int ret;
 
-       /* If thermal commands are not supported, exit without error */
        if (!dell_smbios_class_is_supported(CLASS_INFO))
-               return 0;
+               return -ENODEV;
 
-       /* If thermal modes are not supported, exit without error */
        ret = thermal_get_supported_modes(&supported_modes);
        if (ret < 0)
                return ret;
-       if (!supported_modes)
-               return 0;
 
        platform_device = platform_device_register_simple("dell-pc", PLATFORM_DEVID_NONE, NULL, 0);
        if (IS_ERR(platform_device))
@@ -297,7 +288,6 @@ static int __init dell_init(void)
        if (!dmi_check_system(dell_device_table))
                return -ENODEV;
 
-       /* Do not fail module if thermal modes not supported, just skip */
        ret = thermal_init();
        if (ret)
                goto fail_thermal;