ionic: Remove redundant null pointer checks in ionic_debugfs_add_qcq()
authorLi Zetao <lizetao1@huawei.com>
Tue, 3 Sep 2024 14:31:49 +0000 (22:31 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 4 Sep 2024 23:58:37 +0000 (16:58 -0700)
Since the debugfs_create_dir() never returns a null pointer, checking
the return value for a null pointer is redundant, and using IS_ERR is
safe enough.

Signed-off-by: Li Zetao <lizetao1@huawei.com>
Link: https://patch.msgid.link/20240903143149.2004530-1-lizetao1@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/pensando/ionic/ionic_debugfs.c

index 59e5a9f..c98b4e7 100644 (file)
@@ -123,7 +123,7 @@ void ionic_debugfs_add_qcq(struct ionic_lif *lif, struct ionic_qcq *qcq)
        struct ionic_cq *cq = &qcq->cq;
 
        qcq_dentry = debugfs_create_dir(q->name, lif->dentry);
-       if (IS_ERR_OR_NULL(qcq_dentry))
+       if (IS_ERR(qcq_dentry))
                return;
        qcq->dentry = qcq_dentry;