media: v4l2-tpg: Clamp hue in tpg_s_hue()
authorPeilin Ye <yepeilin.cs@gmail.com>
Fri, 21 Aug 2020 15:13:43 +0000 (17:13 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 26 Aug 2020 16:51:34 +0000 (18:51 +0200)
Setting `hue` by calling tpg_s_hue() directly is risky, since it does not
perform range check. Clamp `hue` to the valid range in tpg_s_hue().

Suggested-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Peilin Ye <yepeilin.cs@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
include/media/tpg/v4l2-tpg.h

index 0b0ddb8..181dcbe 100644 (file)
@@ -325,6 +325,7 @@ static inline void tpg_s_saturation(struct tpg_data *tpg,
 static inline void tpg_s_hue(struct tpg_data *tpg,
                                        s16 hue)
 {
+       hue = clamp_t(s16, hue, -128, 128);
        if (tpg->hue == hue)
                return;
        tpg->hue = hue;