projects
/
linux-2.6-microblaze.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
c0a333d
)
ASoC: SOF: ipc: Fix memory leak in sof_set_get_large_ctrl_data
author
Navid Emamdoost
<navid.emamdoost@gmail.com>
Sun, 27 Oct 2019 21:53:24 +0000
(16:53 -0500)
committer
Mark Brown
<broonie@kernel.org>
Mon, 28 Oct 2019 13:10:42 +0000
(13:10 +0000)
In the implementation of sof_set_get_large_ctrl_data() there is a memory
leak in case an error. Release partdata if sof_get_ctrl_copy_params()
fails.
Fixes:
54d198d5019d
("ASoC: SOF: Propagate sof_get_ctrl_copy_params() error properly")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Link:
https://lore.kernel.org/r/20191027215330.12729-1-navid.emamdoost@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/ipc.c
patch
|
blob
|
history
diff --git
a/sound/soc/sof/ipc.c
b/sound/soc/sof/ipc.c
index
b2f359d
..
086eeea
100644
(file)
--- a/
sound/soc/sof/ipc.c
+++ b/
sound/soc/sof/ipc.c
@@
-572,8
+572,10
@@
static int sof_set_get_large_ctrl_data(struct snd_sof_dev *sdev,
else
err = sof_get_ctrl_copy_params(cdata->type, partdata, cdata,
sparams);
- if (err < 0)
+ if (err < 0) {
+ kfree(partdata);
return err;
+ }
msg_bytes = sparams->msg_bytes;
pl_size = sparams->pl_size;