ASoC: lm49453: fix useless assignment before return
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 26 Mar 2021 22:16:18 +0000 (17:16 -0500)
committerMark Brown <broonie@kernel.org>
Wed, 31 Mar 2021 17:00:37 +0000 (18:00 +0100)
Cppcheck warning:

sound/soc/codecs/lm49453.c:1210:11: style: Variable 'pll_clk' is
assigned a value that is never used. [unreadVariable]

  pll_clk = BIT(4);
          ^

FIXME: What is the correct fix?
/* fll clk slection */
pll_clk = BIT(4);
return 0;

is the assignment redundant or the 'return 0' a mistake?

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210326221619.949961-2-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/lm49453.c

index eb3dd0b..fb0fb23 100644 (file)
@@ -1206,8 +1206,6 @@ static int lm49453_set_dai_sysclk(struct snd_soc_dai *dai, int clk_id,
                break;
        case 48000:
        case 32576:
-               /* fll clk slection */
-               pll_clk = BIT(4);
                return 0;
        default:
                return -EINVAL;