drm/mst: switch to guid_gen() to generate valid GUIDs
authorJani Nikula <jani.nikula@intel.com>
Mon, 12 Aug 2024 12:23:11 +0000 (15:23 +0300)
committerJani Nikula <jani.nikula@intel.com>
Thu, 29 Aug 2024 08:22:37 +0000 (11:22 +0300)
Instead of just smashing jiffies into a GUID, use guid_gen() to generate
RFC 4122 compliant GUIDs.

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Acked-by: Harry Wentland <harry.wentland@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Acked-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240812122312.1567046-2-jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/display/drm_dp_mst_topology.c

index 382e05c..e8695e3 100644 (file)
@@ -2698,18 +2698,10 @@ static void drm_dp_mst_link_probe_work(struct work_struct *work)
 static bool drm_dp_validate_guid(struct drm_dp_mst_topology_mgr *mgr,
                                 guid_t *guid)
 {
-       u64 salt;
-       u8 buf[UUID_SIZE];
-
        if (!guid_is_null(guid))
                return true;
 
-       salt = get_jiffies_64();
-
-       memcpy(&buf[0], &salt, sizeof(u64));
-       memcpy(&buf[8], &salt, sizeof(u64));
-
-       import_guid(guid, buf);
+       guid_gen(guid);
 
        return false;
 }