bpf: Fix memory leak in bpf_core_apply
authorJiri Olsa <jolsa@kernel.org>
Mon, 7 Oct 2024 16:09:58 +0000 (18:09 +0200)
committerAndrii Nakryiko <andrii@kernel.org>
Tue, 8 Oct 2024 03:28:24 +0000 (20:28 -0700)
We need to free specs properly.

Fixes: 3d2786d65aaa ("bpf: correctly handle malformed BPF_CORE_TYPE_ID_LOCAL relos")
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
Link: https://lore.kernel.org/bpf/20241007160958.607434-1-jolsa@kernel.org
kernel/bpf/btf.c

index 75e4fe8..a05da5f 100644 (file)
@@ -8961,6 +8961,7 @@ int bpf_core_apply(struct bpf_core_ctx *ctx, const struct bpf_core_relo *relo,
        if (!type) {
                bpf_log(ctx->log, "relo #%u: bad type id %u\n",
                        relo_idx, relo->type_id);
+               kfree(specs);
                return -EINVAL;
        }