ASoC: atom: fix a missing check of snd_pcm_lib_malloc_pages
authorKangjie Lu <kjlu@umn.edu>
Wed, 26 Dec 2018 02:29:48 +0000 (20:29 -0600)
committerMark Brown <broonie@kernel.org>
Mon, 7 Jan 2019 18:10:03 +0000 (18:10 +0000)
snd_pcm_lib_malloc_pages() may fail, so let's check its status and
return its error code upstream.

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
sound/soc/intel/atom/sst-mfld-platform-pcm.c

index afc5598..91a2436 100644 (file)
@@ -399,7 +399,13 @@ static int sst_media_hw_params(struct snd_pcm_substream *substream,
                                struct snd_pcm_hw_params *params,
                                struct snd_soc_dai *dai)
 {
-       snd_pcm_lib_malloc_pages(substream, params_buffer_bytes(params));
+       int ret;
+
+       ret =
+               snd_pcm_lib_malloc_pages(substream,
+                               params_buffer_bytes(params));
+       if (ret)
+               return ret;
        memset(substream->runtime->dma_area, 0, params_buffer_bytes(params));
        return 0;
 }