cxgb4: clip_tbl: use list_del_init instead of list_del/INIT_LIST_HEAD
authorYang Yingliang <yangyingliang@huawei.com>
Tue, 18 May 2021 13:01:35 +0000 (21:01 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 18 May 2021 20:43:37 +0000 (13:43 -0700)
Using list_del_init() instead of list_del() + INIT_LIST_HEAD()
to simpify the code.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c

index 12fcf84..163efab 100644 (file)
@@ -106,8 +106,7 @@ int cxgb4_clip_get(const struct net_device *dev, const u32 *lip, u8 v6)
        if (!list_empty(&ctbl->ce_free_head)) {
                ce = list_first_entry(&ctbl->ce_free_head,
                                      struct clip_entry, list);
-               list_del(&ce->list);
-               INIT_LIST_HEAD(&ce->list);
+               list_del_init(&ce->list);
                spin_lock_init(&ce->lock);
                refcount_set(&ce->refcnt, 0);
                atomic_dec(&ctbl->nfree);
@@ -179,8 +178,7 @@ found:
        write_lock_bh(&ctbl->lock);
        spin_lock_bh(&ce->lock);
        if (refcount_dec_and_test(&ce->refcnt)) {
-               list_del(&ce->list);
-               INIT_LIST_HEAD(&ce->list);
+               list_del_init(&ce->list);
                list_add_tail(&ce->list, &ctbl->ce_free_head);
                atomic_inc(&ctbl->nfree);
                if (v6)