projects
/
linux-2.6-microblaze.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
45f97ae
)
hinic3: Fix missing napi->dev in netif_queue_set_napi
author
Fan Gong
<gongfan1@huawei.com>
Fri, 12 Sep 2025 06:28:30 +0000
(14:28 +0800)
committer
Paolo Abeni
<pabeni@redhat.com>
Tue, 16 Sep 2025 08:49:06 +0000
(10:49 +0200)
As netif_queue_set_napi checks napi->dev, if it doesn't have it and
it will warn_on and return. So we should use netif_napi_add before
netif_queue_set_napi because netif_napi_add has "napi->dev = dev".
Co-developed-by: Zhu Yikai <zhuyikai1@h-partners.com>
Signed-off-by: Zhu Yikai <zhuyikai1@h-partners.com>
Signed-off-by: Fan Gong <gongfan1@huawei.com>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Link:
https://patch.msgid.link/a17a5a087350eaf2e081dcd879779ca2c69b0908.1757653621.git.zhuyikai1@h-partners.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/huawei/hinic3/hinic3_irq.c
patch
|
blob
|
history
diff --git
a/drivers/net/ethernet/huawei/hinic3/hinic3_irq.c
b/drivers/net/ethernet/huawei/hinic3/hinic3_irq.c
index
33eb908
..
a69b361
100644
(file)
--- a/
drivers/net/ethernet/huawei/hinic3/hinic3_irq.c
+++ b/
drivers/net/ethernet/huawei/hinic3/hinic3_irq.c
@@
-42,11
+42,11
@@
static void qp_add_napi(struct hinic3_irq_cfg *irq_cfg)
{
struct hinic3_nic_dev *nic_dev = netdev_priv(irq_cfg->netdev);
+ netif_napi_add(nic_dev->netdev, &irq_cfg->napi, hinic3_poll);
netif_queue_set_napi(irq_cfg->netdev, irq_cfg->irq_id,
NETDEV_QUEUE_TYPE_RX, &irq_cfg->napi);
netif_queue_set_napi(irq_cfg->netdev, irq_cfg->irq_id,
NETDEV_QUEUE_TYPE_TX, &irq_cfg->napi);
- netif_napi_add(nic_dev->netdev, &irq_cfg->napi, hinic3_poll);
napi_enable(&irq_cfg->napi);
}