iio: core: Fix an error pointer vs NULL bug in devm_iio_device_alloc()
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 15 May 2021 09:56:39 +0000 (12:56 +0300)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 17 May 2021 13:09:49 +0000 (14:09 +0100)
The devm_iio_device_alloc() function is supposed to return NULL and not
error pointers.  Returning an error pointer will lead to a crash in the
callers.

Fixes: cf5724e91515 ("iio: core: simplify some devm functions")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Link: https://lore.kernel.org/r/YJ+a1yaMu2QNATgt@mwanda
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/industrialio-core.c

index bfa20a3..75e92ba 100644 (file)
@@ -1711,7 +1711,7 @@ struct iio_dev *devm_iio_device_alloc(struct device *parent, int sizeof_priv)
        ret = devm_add_action_or_reset(parent, devm_iio_device_release,
                                       iio_dev);
        if (ret)
-               return ERR_PTR(ret);
+               return NULL;
 
        return iio_dev;
 }