block, bfq: remove redundant check in bfq_put_cooperator
authorKemeng Shi <shikemeng@huaweicloud.com>
Mon, 16 Jan 2023 09:51:51 +0000 (17:51 +0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 30 Jan 2023 03:03:49 +0000 (20:03 -0700)
We have already avoided a circular list in bfq_setup_merge (see comments
in bfq_setup_merge() for details), so bfq_queue will not appear in it's
new_bfqq list. Just remove this check.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230116095153.3810101-7-shikemeng@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bfq-iosched.c

index 4a17b22..dbee5c6 100644 (file)
@@ -5429,8 +5429,6 @@ void bfq_put_cooperator(struct bfq_queue *bfqq)
         */
        __bfqq = bfqq->new_bfqq;
        while (__bfqq) {
-               if (__bfqq == bfqq)
-                       break;
                next = __bfqq->new_bfqq;
                bfq_put_queue(__bfqq);
                __bfqq = next;