spi: amd: Drop duplicate driver data assignments
authorLukas Wunner <lukas@wunner.de>
Mon, 4 May 2020 11:12:03 +0000 (13:12 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 4 May 2020 16:18:47 +0000 (17:18 +0100)
The AMD SPI driver calls platform_set_drvdata() on probe even though
it's already been set by __spi_alloc_controller().  Likewise, it calls
platform_set_drvdata() on remove even though it's going to be set by
__device_release_driver().  Drop the duplicate assignments.

Signed-off-by: Lukas Wunner <lukas@wunner.de>
Link: https://lore.kernel.org/r/499f8ad4759c2ff0f586e0459fb9a293faecff6d.1588590210.git.lukas@wunner.de
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-amd.c

index a4248b9..d3e3516 100644 (file)
@@ -287,7 +287,6 @@ static int amd_spi_probe(struct platform_device *pdev)
                dev_err(dev, "error %d registering SPI controller\n", err);
                goto err_free_master;
        }
-       platform_set_drvdata(pdev, amd_spi);
 
        return 0;
 
@@ -303,7 +302,6 @@ static int amd_spi_remove(struct platform_device *pdev)
 
        spi_unregister_master(amd_spi->master);
        spi_master_put(amd_spi->master);
-       platform_set_drvdata(pdev, NULL);
 
        return 0;
 }