ARM: dts: stm32: lxa-mc1: Fix kernel warning about PHY delays
authorHolger Assmann <h.assmann@pengutronix.de>
Fri, 7 Aug 2020 15:03:56 +0000 (17:03 +0200)
committerAlexandre Torgue <alexandre.torgue@st.com>
Wed, 23 Sep 2020 16:37:02 +0000 (18:37 +0200)
The KSZ9031 PHY skew timings for rxc/txc, originally set to achieve
the desired phase shift between clock- and data-signal, now trigger a
kernel warning when used in rgmii-id mode:

 *-skew-ps values should be used only with phy-mode = "rgmii"

This is because commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode
support for the KSZ9031 PHY") now configures own timings when
phy-mode = "rgmii-id". Device trees wanting to set their own delays
should use phy-mode "rgmii" instead as the warning prescribes.

The "standard" timings now used with "rgmii-id" work fine on this
board, so drop the explicit timings in the device tree and thereby
silence the warning.

Fixes: 666b5ca85cd3 ("ARM: dts: stm32: add STM32MP1-based Linux Automation MC-1 board")
Signed-off-by: Holger Assmann <h.assmann@pengutronix.de>
Acked-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Signed-off-by: Alexandre Torgue <alexandre.torgue@st.com>
arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts

index 5700e6b..b85025d 100644 (file)
                        reset-gpios = <&gpiog 0 GPIO_ACTIVE_LOW>; /* ETH_RST# */
                        interrupt-parent = <&gpioa>;
                        interrupts = <6 IRQ_TYPE_EDGE_FALLING>; /* ETH_MDINT# */
-                       rxc-skew-ps = <1860>;
-                       txc-skew-ps = <1860>;
                        reset-assert-us = <10000>;
                        reset-deassert-us = <300>;
                        micrel,force-master;