projects
/
linux-2.6-microblaze.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
4e08a28
)
irqchip/wpcm450: Fix memory leak in wpcm450_aic_of_init()
author
Wei Yongjun
<weiyongjun1@huawei.com>
Tue, 15 Nov 2022 09:25:32 +0000
(09:25 +0000)
committer
Marc Zyngier
<maz@kernel.org>
Sat, 26 Nov 2022 13:29:48 +0000
(13:29 +0000)
If of_iomap() failed, 'aic' should be freed before return. Otherwise
there is a memory leak.
Fixes:
fead4dd49663
("irqchip: Add driver for WPCM450 interrupt controller")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link:
https://lore.kernel.org/r/20221115092532.1704032-1-weiyongjun@huaweicloud.com
drivers/irqchip/irq-wpcm450-aic.c
patch
|
blob
|
history
diff --git
a/drivers/irqchip/irq-wpcm450-aic.c
b/drivers/irqchip/irq-wpcm450-aic.c
index
0dcbeb1
..
91df62a
100644
(file)
--- a/
drivers/irqchip/irq-wpcm450-aic.c
+++ b/
drivers/irqchip/irq-wpcm450-aic.c
@@
-146,6
+146,7
@@
static int __init wpcm450_aic_of_init(struct device_node *node,
aic->regs = of_iomap(node, 0);
if (!aic->regs) {
pr_err("Failed to map WPCM450 AIC registers\n");
+ kfree(aic);
return -ENOMEM;
}