drm/i915/display: use clk_off name to avoid double negation
authorLucas De Marchi <lucas.demarchi@intel.com>
Tue, 17 Dec 2019 23:05:28 +0000 (15:05 -0800)
committerLucas De Marchi <lucas.demarchi@intel.com>
Thu, 19 Dec 2019 01:53:16 +0000 (17:53 -0800)
Instead of "ungated" use the same name for the variable as the bitfield,
making it clearer what's the intent of the checks.

Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Clinton Taylor <Clinton.A.Taylor@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191217230529.25092-2-lucas.demarchi@intel.com
drivers/gpu/drm/i915/display/intel_ddi.c

index 6e419b1..9d2b724 100644 (file)
@@ -3008,12 +3008,10 @@ static void icl_sanitize_port_clk_off(struct drm_i915_private *dev_priv,
        val = I915_READ(ICL_DPCLKA_CFGCR0);
        for_each_port_masked(port, port_mask) {
                enum phy phy = intel_port_to_phy(dev_priv, port);
+               bool ddi_clk_off = val & icl_dpclka_cfgcr0_clk_off(dev_priv,
+                                                                  phy);
 
-               bool ddi_clk_ungated = !(val &
-                                        icl_dpclka_cfgcr0_clk_off(dev_priv,
-                                                                  phy));
-
-               if (ddi_clk_needed == ddi_clk_ungated)
+               if (ddi_clk_needed == !ddi_clk_off)
                        continue;
 
                /*