nfc: mrvl: skip impossible NCI_MAX_PAYLOAD_SIZE check
authorKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Fri, 28 May 2021 12:41:54 +0000 (08:41 -0400)
committerJakub Kicinski <kuba@kernel.org>
Fri, 28 May 2021 22:05:55 +0000 (15:05 -0700)
The nci_ctrl_hdr.plen field us u8, so checkign if it is bigger than
NCI_MAX_PAYLOAD_SIZE does not make any sense.  Fix warning reported by
Smatch:

    drivers/nfc/nfcmrvl/i2c.c:52 nfcmrvl_i2c_read() warn:
        impossible condition '(nci_hdr.plen > 255) => (0-255 > 255)'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Link: https://lore.kernel.org/r/20210528124200.79655-6-krzysztof.kozlowski@canonical.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/nfc/nfcmrvl/i2c.c

index bafd9b5..3c9bbee 100644 (file)
@@ -49,11 +49,6 @@ static int nfcmrvl_i2c_read(struct nfcmrvl_i2c_drv_data *drv_data,
                return -EBADMSG;
        }
 
-       if (nci_hdr.plen > NCI_MAX_PAYLOAD_SIZE) {
-               nfc_err(&drv_data->i2c->dev, "invalid packet payload size\n");
-               return -EBADMSG;
-       }
-
        *skb = nci_skb_alloc(drv_data->priv->ndev,
                             nci_hdr.plen + NCI_CTRL_HDR_SIZE, GFP_KERNEL);
        if (!*skb)