net: tap: Remove generic .ndo_get_stats64
authorBreno Leitao <leitao@debian.org>
Mon, 4 Mar 2024 18:38:08 +0000 (10:38 -0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 6 Mar 2024 02:32:33 +0000 (18:32 -0800)
Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is
configured") moved the callback to dev_get_tstats64() to net core, so,
unless the driver is doing some custom stats collection, it does not
need to set .ndo_get_stats64.

Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it
doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64
function pointer.

Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Link: https://lore.kernel.org/r/20240304183810.1474883-2-leitao@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/tun.c

index 6c594a3..8d258e2 100644 (file)
@@ -1338,7 +1338,6 @@ static const struct net_device_ops tap_netdev_ops = {
        .ndo_select_queue       = tun_select_queue,
        .ndo_features_check     = passthru_features_check,
        .ndo_set_rx_headroom    = tun_set_headroom,
-       .ndo_get_stats64        = dev_get_tstats64,
        .ndo_bpf                = tun_xdp,
        .ndo_xdp_xmit           = tun_xdp_xmit,
        .ndo_change_carrier     = tun_net_change_carrier,