dmaengine: idxd: Remove unnecessary synchronize_irq() before free_irq()
authorMinghao Chi <chi.minghao@zte.com.cn>
Mon, 16 May 2022 11:54:12 +0000 (11:54 +0000)
committerVinod Koul <vkoul@kernel.org>
Mon, 16 May 2022 17:49:43 +0000 (23:19 +0530)
Calling synchronize_irq() right before free_irq() is quite useless. On one
hand the IRQ can easily fire again before free_irq() is entered, on the
other hand free_irq() itself calls synchronize_irq() internally (in a race
condition free way), before any state associated with the IRQ is freed.

Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Link: https://lore.kernel.org/r/20220516115412.1651772-1-chi.minghao@zte.com.cn
Acked-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/idxd/device.c

index 8b1f859..1143886 100644 (file)
@@ -1179,7 +1179,6 @@ void idxd_wq_free_irq(struct idxd_wq *wq)
        if (wq->type != IDXD_WQT_KERNEL)
                return;
 
-       synchronize_irq(ie->vector);
        free_irq(ie->vector, ie);
        idxd_flush_pending_descs(ie);
        if (idxd->request_int_handles)